Cron has a few functions for looking at AWS Batch Jobs and pulling out the Cloudwatch LogName from them. This is done because the LogName will never expire while the Batch Job eventually will, leaving us unable to retrieve logs for that job. The functions were only used by Cron so I moved them up to Cron's level rather than have them clutter up interfaces.
Review Checklist
Goals
[ ] Does it solve the problem?
[ ] Is it the simplest implementation of that solution?
Does it yak shave? Does it introduce new dependencies that aren't necessary?
[ ] Does it decrease modularity?
Does the user of a module need to import another module to use this one?
If we want to delete these changes, how easy is that?
[ ] Does it clarify our domain?
What things does it refine? What things get added? How does this pave the way for new things?
Are things named in such a way that a domain expert can find them?
[ ] Does it introduce non-domain concepts?
What does the user of this need to learn outside of our domain in order to use this?
Testing
[ ] Do we integration test changes to external services?
Type of change
Description
Depends on https://github.com/ReconfigureIO/platform/pull/271
Cron has a few functions for looking at AWS Batch Jobs and pulling out the Cloudwatch LogName from them. This is done because the LogName will never expire while the Batch Job eventually will, leaving us unable to retrieve logs for that job. The functions were only used by Cron so I moved them up to Cron's level rather than have them clutter up interfaces.
Review Checklist
Goals
[ ] Does it solve the problem?
[ ] Is it the simplest implementation of that solution? Does it yak shave? Does it introduce new dependencies that aren't necessary?
[ ] Does it decrease modularity? Does the user of a module need to import another module to use this one? If we want to delete these changes, how easy is that?
[ ] Does it clarify our domain? What things does it refine? What things get added? How does this pave the way for new things? Are things named in such a way that a domain expert can find them?
[ ] Does it introduce non-domain concepts? What does the user of this need to learn outside of our domain in order to use this?
Testing
[ ] Do we integration test changes to external services?
[ ] Do we unit test code we can change?