search

ReconfigureIO / reco-sdaccel

0 stars 1 forks source link

Parse yaml robustly #212

Closed pwaller closed 6 years ago

pwaller commented 6 years ago

Replace old shell script eval approach with explicitly listed variables parsed from YAML.

Supercedes #210.

CampGareth commented 6 years ago

@reconfig-bot r+

reconfig-bot commented 6 years ago

:pushpin: Commit 2d10718 has been approved by CampGareth

reconfig-bot commented 6 years ago

:hourglass: Testing commit 2d10718 with merge c02e9a2...

reconfig-bot commented 6 years ago

:broken_heart: Test failed - status-jenkins

pwaller commented 6 years ago

@CampGareth, hmm, python does not appear to be available in the environment. We tested the centos image together and verified it was there, were we looking at the wrong thing? Where do I find the environment the jenkins test is running under?

http://jenkins.nerabus-infra.com:8080/blue/organizations/jenkins/reconfigureio%2Freco-sdaccel/detail/auto/284/pipeline#step-51-log-66

/mnt/sdaccel-builder: line 28: python: command not found
CampGareth commented 6 years ago

@pwaller looks like python's available under centos but not on jenkins or in the docker container jenkins is using. During the test-go stage it runs docker-compose run --rm test make test

bohde commented 6 years ago

@reconfig-bot r+

reconfig-bot commented 6 years ago

:pushpin: Commit 395f558 has been approved by joshbohde

bohde commented 6 years ago

@reconfig-bot rollup

reconfig-bot commented 6 years ago

:hourglass: Testing commit 395f558 with merge a88ce4c...

reconfig-bot commented 6 years ago

:broken_heart: Test failed - status-jenkins

CampGareth commented 6 years ago

"Python3 command not found" eh? That's installed in the base image:/

bohde commented 6 years ago

@reconfig-bot r+

reconfig-bot commented 6 years ago

:pushpin: Commit 965fd17 has been approved by joshbohde

reconfig-bot commented 6 years ago

:hourglass: Testing commit 965fd17 with merge ab71d6d...

reconfig-bot commented 6 years ago

:broken_heart: Test failed - status-jenkins

bohde commented 6 years ago

@reconfig-bot retry

reconfig-bot commented 6 years ago

:hourglass: Testing commit 965fd17 with merge 056c49e...

reconfig-bot commented 6 years ago

:sunny: Test successful - status-jenkins Approved by: joshbohde Pushing 056c49e0383ce03006788ee0cc02e118c5448e3d to master...