search

ReconfigureIO / reco-sdaccel

0 stars 1 forks source link

upload sim reports to platform #230

Closed CampGareth closed 5 years ago

CampGareth commented 6 years ago

TODO Before Merging

It turns out sdaccel builder generates reports for sims, we just don't upload them, so let's start doing that!

Depends on a platform PR to add an endpoint for simulation report upload which has now been merged. This one: https://github.com/ReconfigureIO/platform/pull/264

CampGareth commented 6 years ago

urm... well that's an unrelated error. Seems transient, further CI runs have been green. :/

%Error: Specified --top-module 'sda_kernel_wrapper_gmem' was not found in design.

%Error: Exiting due to 1 error(s)

%Error: Command Failed /usr/bin/verilator_bin -Wall --lint-only -I.reco-work/sdaccel/verilog/includes -I.reco-work/sdaccel/verilog/library .reco-work/sdaccel/verilog/main.v '-DAXI_MASTER_DATA_WIDTH=64' '-DAXI_MASTER_HAS_WID=1' --top-module sda_kernel_wrapper_gmem --report-unoptflat -Wno-UNUSED -Wno-UNDRIVEN -Wno-REDEFMACRO -Wno-DECLFILENAME
rosieyohannan commented 5 years ago

reco v0.7.0

CampGareth commented 5 years ago

This PR would function but the report URL is not an environment variable platform currently provides. That's something I need to fix.

zynaptic commented 5 years ago

@CampGareth Can you add a description of the change to the Release.md file before doing the merge, so that it will go into the changelog on release?

zynaptic commented 5 years ago

@reconfig-bot r+

reconfig-bot commented 5 years ago

:pushpin: Commit 21cd4ef has been approved by zynaptic

reconfig-bot commented 5 years ago

:hourglass: Testing commit 21cd4ef with merge 51aedce...

reconfig-bot commented 5 years ago

:sunny: Test successful - status-jenkins Approved by: zynaptic Pushing 51aedced3dff34f3066a160396306757ee95de12 to master...