Remove reco-check-bundle's dependency on windows reco-check

CampGareth commented 6 years ago

We recently tried to run a compiler release but it failed:

aws s3 cp "s3://reconfigure.io/reco-check/releases/reco-check-v0.23.0-x86_64-pc-windows-msvc-release.tar.gz" downloads/reco-check-v0.23.0-x86_64-pc-windows-msvc.tar.gz
fatal error: An error occurred (404) when calling the HeadObject operation: Key "reco-check/releases/reco-check-v0.23.0-x86_64-pc-windows-msvc-release.tar.gz" does not exist
Makefile:29: recipe for target 'downloads/reco-check-v0.23.0-x86_64-pc-windows-msvc.tar.gz' failed
make[1]: *** [downloads/reco-check-v0.23.0-x86_64-pc-windows-msvc.tar.gz] Error 1
rm downloads/reco-check-v0.23.0-x86_64-apple-darwin.tar.gz downloads/reco-check-v0.23.0-x86_64-unknown-linux.tar.gz
make[1]: Leaving directory '/var/lib/jenkins/workspace/release-sdaccel-builder/reco-check-bundle'
Makefile:226: recipe for target 'upload-reco-check-bundle' failed
make: *** [upload-reco-check-bundle] Error 2

It's trying to download the windows release of reco-check v0.23.0, however we recently disabled appveyor on the eteak repository and one of its jobs was to upload windows releases of reco-check. Since reco-check is on the way out and windows is a small-to-absent part of our user base, we felt it was best to remove this dependency rather than start appveyor again.

zynaptic commented 6 years ago

@reconfig-bot r+

reconfig-bot commented 6 years ago

:pushpin: Commit c3bf707 has been approved by zynaptic

reconfig-bot commented 6 years ago

:hourglass: Testing commit c3bf707 with merge e396f4f...

reconfig-bot commented 6 years ago

:sunny: Test successful - status-jenkins Approved by: zynaptic Pushing e396f4facb51d1334d32d9d2f707b063302fe83d to master...

ReconfigureIO / reco-sdaccel

Remove reco-check-bundle's dependency on windows reco-check #238