search

ReconfigureIO / reco-sdaccel

0 stars 1 forks source link

test_afi_generation.sh hides build output #246

Open CampGareth opened 5 years ago

CampGareth commented 5 years ago

https://github.com/ReconfigureIO/reco-sdaccel/blob/d8282e472bfbabb79a45dc13c910bb22f42023f7/ci/test_afi_generation.sh#L21

test_afi_generation.sh is the script underpinning the 'test hw builds' stage of testing on jenkins. It runs reco-aws build and blocks until it finishes. It also redirects stderr output from the running reco-aws to a temporary file. 99% of reco-aws's output is on stderr. After reco-aws returns test_afi_generation cats the temporary file containing reco-aws's log output.

If reco-aws hangs forever for some reason (say AFI generation goes wrong) then we never see any output.

CampGareth commented 5 years ago

I think this commit and its fixup help the situation but aren't the best solution: https://github.com/ReconfigureIO/reco-sdaccel/pull/240/commits/9b29e78a0e088bbc042518ff27d8398579e327e5 https://github.com/ReconfigureIO/reco-sdaccel/pull/240/commits/a39d6fbf6c91647f0725ac8a3af602207b935e2c