Do not overwrite network errors.

ReconfigureIO / reco

A command line tool for interacting with Reconfigure.io services

Apache License 2.0

6 stars 3 forks source link

Do not overwrite network errors. #28

Closed CampGareth closed 6 years ago

CampGareth commented 6 years ago

In the event of a network error reco currently outputs errors about an invalid token. This PR reports the error returned by request.go which may be 'invalid token' or a network error.

pwaller commented 6 years ago

A straightforward fix if ever there was one :). Thinking "outside the diff":

How do I test this fix, e.g, manually.
Are there cases where the error should be coerced to errAuthFailedInvalidToken? AFAICT, that symbol is now unused.
Are there other cases where errors are being coerced inappropriately (and suppressing important diagnostic information?). What patterns are we using to avoid this generally?

CampGareth commented 6 years ago

To test this fix you could spin up a docker container with no network interface using --net none. As for the others I'll make a card on trello to consider this further, there are likely to be quite wide-reaching changes required.