ui-timepicker="timePickerOptions" doesn't work

[weicao]

you cannot access other scope variables except those included in directive's scope, according to angular document https://docs.angularjs.org/guide/directive

after comment out these code, it works,

return { restrict: 'A', require: 'ngModel', // scope: { // ngModel: '=', // baseDate: '=', // },

btw, thanks for your great job

[timmipetit]

Hi, thanks for reporting this. We switched to an isolated scope to follow the Angular best practices. Can you give a use case when prototypical inherited scope would be better for you?

[borislit]

+1

On line 57 $parse(attrs.uiTimepicker)(scope) returns undefined. Pephaps, instead of using attrs, this should be passed using another scope variable (in addition to ngModal and baseDate)

[timmipetit]

Thanks for finding this issue! Indeed, it seems that passing custom options to uiTimePicker doesn't work at this moment. I will start working on a fix.

[timmipetit]

This should be fixed in 0.4.1

[borislit]

Thanks. Ill check it out