Edit Profile - Add Profile Picture Feature

RecursiveThinking / recursive_thinking_website

Recursive Thinking Website

5 stars 2 forks source link

Edit Profile - Add Profile Picture Feature #16

Closed amnevins closed 6 years ago

amnevins commented 6 years ago

Build the Add Profile Picture Feature.
Considerations/Guidelines:

Should be a file picker
Optimally an html5 standard that supports mobile

sethborne commented 6 years ago

FYI - the changes made had an issue when the page was resized (wider) at a certain point, it broke off the image.

I fixed this today by removing the wrapping label tags, and changing them to div tags. now the span follows the image no matter the resize

clayton-perszyk commented 6 years ago

Hmmm... seems to have broken the file upload functionality. I'll look at it later, but i think the label needs to be in there somehow, or it wont work. Otherwise we have to keep the default file type displayed by the browser.

sethborne commented 6 years ago

actually - i think i just got a solution

I just wrapped your label in the div...it doesn't float, and the dialog still come up. Pushing it now.

clayton-perszyk commented 6 years ago

NIce! That's what I was thinking of doing.