Closed amnevins closed 6 years ago
2 things important to think about: Validation ~ via good html input types Cognito has a built in validator I already configured so at least inputs are length minimums of 1 for everything and maximums that vary and there all strings. Error Alerts - Customers should see a good error below the input or at the top of modal if they mess up the required field somehow.
Austin/Experts - so I'm wondering - for the Error alerts/messages - should we have a global function that handles this for everything? (like errors on logins, but also errors on inputs/data unavailabe, etc?)
Maybe something like a function that takes the message type and an input string? (just a thought)
Good idea. In your vision does this function do the validation or only display the error?
Suppose it depends on size. If it gets big I'd split it up.
But mentally, I'd prefer to have (regardless of size) a validation function (or maybe a couple? again...depending) which does that logic, and just pushes out what needs to get displayed to the message function.
separate them into what they do essentially - that makes the most sense to me but def doesn't have to be
Yeah I’d approach it pretty much exactly like that Seth.
You can rely on html5 input type validation knowing that cognito will do hard validation on their side this can actually be pretty lightweght. Love the idea for the re usable alert, makes logging and analytics a dream later.
Doing the alert component might be a smaller and seperate task?
Working on confirmation, basic sign up is there
Current Sign up flow complete as per https://github.com/RecursiveThinking/recursive_thinking_website/commit/30bbf94dc68b15764d1f6296c537c1e269ab8f20 We can rethink this when @MynockSpit as explored Slack integration more
At least for now this affords us the flexibility to start signing in and returning/saving info on the user object
Customer should be able to sign up and be routed to dashboard.