Red-Studio-Ragnarok / Fancier-Block-Particles

Turn boring particles into fancier particles!
https://www.curseforge.com/minecraft/mc-mods/fbp
GNU General Public License v3.0
10 stars 4 forks source link

[Fancy Block Placement] Ambient Occlusion Missing From Dummy Block & Weird Behaviors #12

Open Krutoy242 opened 1 year ago

Krutoy242 commented 1 year ago

Describe the bug

Placing blocks causing various rendering glitches, including:

  1. Double of block on same place

    For several frames, there is two blocks on same place - one moving and second stand still

  2. Shadow blinking around block

    When you place block, shadow appear for split second, then block "falls" without shadow, then shadow appear again when animation ends

  3. Disappearing of block at last moment

    Just frame before animation of block placement finished, block disappear, only frame of block visible

Double block and and shadow blink:

KqqZSYUxYW

Transparent block at last moment

javaw_OsVn6u8HlH

Specification:

Additional context

Happen on E2E-E modpack.

Desoroxxx commented 1 year ago

Thanks for the report!

For the first point I am pretty sure this is fixed in the dev builds of FBP.

For the third, I need to talk with some peoples but I think this cannot be fixed (Actually I may have an idea, note to myself: Look into the materials property for the dummy block)

For the fifth point I never seen that behavior maybe it's also fixed in the dev build.

If you do not mind you could try with a test build and see if the issues are the same, they are posted on my Discord in the dev-builds channel (https://discord.gg/CBpqejmuWx)

I will release an up to date build right now.

Krutoy242 commented 1 year ago

(oh, i just noticed, that when i added sub-descriptions GitHub incrememt numbers 😁)

Krutoy242 commented 1 year ago

If you do not mind you could try with a test build and see if the issues are the same, they are posted on my Discord in the dev-builds channel (discord.gg/CBpqejmuWx)

Ok, i just tested dev build Fancier-Block-Particles-0.8-Dev-9. All three problems still there. Observing no changes.

Desoroxxx commented 1 year ago

Just came to mind, are you using Optifine?

Krutoy242 commented 1 year ago

Yes, i do

Desoroxxx commented 1 year ago

Optifine might be causing this

Krutoy242 commented 1 year ago

Optifine might be causing this

I removed Optifine and tested again. All three problems still there, nothing fixed.

I used 0.8-Dev-9 version for test.

Update: Tested on 0.8-Dev-10 too. Still issues.

Desoroxxx commented 1 year ago

I could not reproduce the issue with any optimization mod I am suspecting either mod conflict or nvidia nvidiaing

Krutoy242 commented 1 year ago

Then I could try binary search mod that causing it (duh). This could take week or two.

Desoroxxx commented 1 year ago

First thing try in an instance with only FBP to see if it's not nvidia nvidiaing

Krutoy242 commented 1 year ago

Just tested, all three problems happen when barely no mods installed (only BoP and RecurrentComplex).

Through, problem with second invisible block not obivious, until i spammed zombies to create FPS lags.

DyVnsIXwBS

Desoroxxx commented 1 year ago

Yeah, this issue seems like a mix of Nvidia Nvidiaing and just me not being able to go faster than your CPU can go.

And putting the Fancy Block animation on a separate thread is probably impossible without breaking a bunch of mods

Desoroxxx commented 1 year ago

But I may be able to fix the shadow blinking.

But I am currently waiting Meldexun to make a pr of his big changes, since I don't want to cause more merge conflicts.

Krutoy242 commented 1 year ago

Nvidia Nvidiaing

Is that means, that "double block" and "transparent frame" will be issue for FBP for NVidia cards forever?

Nvidia is kinda popular type of video cards... I'm not sure whether to add this mod to the modpack, if it will glitch on all Nvidia cards 🤕

Desoroxxx commented 1 year ago

Well you can just turn of fancy block placement but from my understanding I currently cannot do much

Krutoy242 commented 1 year ago

Then, I would appreciate if you not close this issue until its fixed, so I could keep subscribed to see when it fixed and then install on modpack.

P.S. I didnt knew that NVidia actually have more than 75% of market

image

Desoroxxx commented 1 year ago

Then, I would appreciate if you not close this issue until its fixed, so I could keep subscribed to see when it fixed and then install on mudpack.

I will keep it open for the ambient occlusion missing problem (.3) but the rest I literally cannot fix at least if it stay untraceable.

Desoroxxx commented 1 year ago

Project: Pacificus Ponens