Red-Studio-Ragnarok / Fancier-Block-Particles

Turn boring particles into fancier particles!
https://www.curseforge.com/minecraft/mc-mods/fbp
GNU General Public License v3.0
10 stars 4 forks source link

[Fancy Block Placement] Placing snow on top of snow while the animation is still playing crash #18

Open Krutoy242 opened 1 year ago

Krutoy242 commented 1 year ago

Rapid placing Snow Layers on snow causing freeze of game and crash.

The reproduce steps are similar to other issue: https://github.com/Red-Studio-Ragnarok/Fancier-Block-Particles/issues/13 - i just hold right mouse button.

Exception caught during firing event net.minecraftforge.event.entity.player.PlayerInteractEvent$RightClickBlock@1387c55:
java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=layers, clazz=class java.lang.Integer, values=[1, 2, 3, 4, 5, 6, 7, 8]} as it does not exist in BlockStateContainer{block=minecraft:air, properties=[]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:209) ~[awu$a.class:?]
    at snownee.snow.ModSnowBlock.isReplaceable(ModSnowBlock.java:395) ~[ModSnowBlock.class:?]
    at io.redstudioragnarok.FBP.handler.EventHandler.onInteractionEvent(EventHandler.java:262) ~[EventHandler.class:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_4626_EventHandler_onInteractionEvent_RightClickBlock.invoke(.dynamic) ~[?:?]

dwm_Lf5HfxCEJ3 debug.log

Additional context Version: Fancier-Block-Particles-0.8-Dev-10 SnowRealMagic-1.12.2-0.6.2 Happen on E2E-E modpack https://www.curseforge.com/minecraft/modpacks/enigmatica-2-expert-extended - OS: Windows 10 - CPU: i5-7400 @ 3.00 GHz - GPU: GTX 1050 Ti - RAM Allocated: 6GB
Desoroxxx commented 1 year ago

Project: Pacificus Ponens

Desoroxxx commented 1 year ago

Update

I have discovered that the crash is simply due to snow being placed on snow while animating. So, nothing to do with snow real magic.

This will be fixed when the Pacificus Poens project is done, as well as a ton of other issues.