Red-Studio-Ragnarok / Fancier-Block-Particles

Turn boring particles into fancier particles!
https://www.curseforge.com/minecraft/mc-mods/fbp
GNU General Public License v3.0
10 stars 4 forks source link

[Fancier Weather] Rain instead of snow in extreme hills biome #22

Open Meldexun opened 1 year ago

Meldexun commented 1 year ago

Describe the bug

Tried to do a small test for #21 to make sure everything still works and noticed that it is now raining in the extreme hills biome instead of snowing.

Reproducibility

Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

To Reproduce

Steps to reproduce the behavior:

  1. Go to ExtremeHills biome
  2. Run /weather rain
  3. See rain instead of snow

Expected behavior

Snow particles in the extreme hills biome while it is raining.

Screenshots or/and videos

This is the same world and position as the videos from #20.

2023-03-06_14 04 36

Versions

Specification:

All of these info below are not necessary but may become necessary depending on the issue

Desoroxxx commented 1 year ago

Oh no Mojang what have you done...

Does this happen only with that biome? If you remove FBP do you see snow?

Meldexun commented 1 year ago

Does this happen only with that biome?

I haven't done a lot of testing but I suspect that the extreme hills biome is only a partial snowy biome and similar biomes will have the same issue.

If you remove FBP do you see snow?

Yes. That's also why there are snow layer blocks on the ground.

Desoroxxx commented 1 year ago

Weird, FBP checks against the getEnableSnow method from Minecraft, so either this method is broken, or somethings is off image