Red-Studio-Ragnarok / Opticraft

Opticraft – A Complete Guide & Modpack for an Optimized 1.12.2 Modded Experience
https://red-studio-ragnarok.github.io/Opticraft/
20 stars 0 forks source link

FermiumASM instead CensoredASM #14

Closed XvaleX10 closed 7 months ago

XvaleX10 commented 7 months ago

Why the mod should be added to Opticraft

As with the original and the forks, FermiumASM makes multiple improvements, optimizations, and bug fixes to Minecraft, including but not limited to:

Link to the real mod page

https://www.curseforge.com/minecraft/mc-mods/fermiumasm Ex: https://www.curseforge.com/minecraft/mc-mods/fbp

Optional Informations

Additional information is not a criteria in any way it just helps me in my research

KorewaLidesu commented 7 months ago

Warning: This is my opinion about the mod, please take it as reference.

Currently stage of FermiumASM hasn't improved much outside of CensoredASM from what I can tell here:

Yes, I do know that it has new commits comparing to the mod's parent. But, unless there is a benchmark that can show improvement in performance, I don't think it is worth to switch the mod.

XvaleX10 commented 7 months ago

Warning: This is my opinion about the mod, please take it as reference.

Currently stage of FermiumASM hasn't improved much outside of CensoredASM from what I can tell here:

  • Rebranding.
  • Replace depencencies.
  • Remove VFix "random author blame" feature.
  • Remove hard depend on old Spark version.

Yes, I do know that it has new commits comparing to the mod's parent. But, unless there is a benchmark that can show improvement in performance, I don't think it is worth to switch the mod.

I did a test in my modpack with 115 mods and I got a better result with FermiumASM than CensoredASM with 150mb less ram usage and almost 30 fps more Also with FermiumASM I reached 515 fps while the maximum with CensoredASM was 485 fps

Desoroxxx commented 7 months ago

After carefully looking at the difference between the source code of both mods, the only real difference lowers performance.

skmedix/NormalASM@dev/sync-5.14...fonnymunkey:FermiumASM:dev/sync-5.14#diff-fb36776548L30-R32

In addition Fermium ASM is outdated and lacks important changes.

fonnymunkey commented 5 months ago

Can you elaborate on what the performance issues are, I have not had this reported before and I see no changes that would cause such an issue?

Additionally it is now fully up to date along with newer changes, Curseforge approval took nearly 2 weeks so I preferred to bundle multiple changes at once over staying fully up to date instantly.

Desoroxxx commented 4 months ago

Can you elaborate on what the performance issues are, I have not had this reported before and I see no changes that would cause such an issue?

Additionally it is now fully up to date along with newer changes, Curseforge approval took nearly 2 weeks so I preferred to bundle multiple changes at once over staying fully up to date instantly.

@Inject for example has lower performance than @ModifyReturnValue additionally it completly destroys compatibility with other mods

fonnymunkey commented 4 months ago

From my testing the performance difference is non-significant during actual gameplay, however for the sake of compatibility concerns I've restored the MixinExtras usage in the latest 5.23 release which is now uploaded, along with re-synced upstream (Which is now ahead of NormalASM.)