Latest Valkyrie and RenderLib incompatibility

Red-Studio-Ragnarok / Valkyrie

As the Valkyries' whispers guide us, we carve our path to a Valhalla of optimized Minecraft gameplay.

MIT License

20 stars 4 forks source link

Latest Valkyrie and RenderLib incompatibility #23

Open shizotoaster opened 1 year ago

shizotoaster commented 1 year ago

Describe the bug

A clear and concise description of what the bug is.

Valkyrie is incompatible with RenderLib. That didn't happen before so it is probably something with latest updates of valkyrie or RenderLib

Reproducibility

[x] I reproduced this issue with as few other mods as possible installed.
[ ] I am unable to reproduce this issue consistently.

To Reproduce

Steps to reproduce the behavior:

Install Valkyrie alongside RenderLib
Launch the game
BOOM! Mixin conflict crash

Expected behavior

Game launches and works correctly

Logs or/and crash reports

https://mclo.gs/CdteFbu

Versions

Valkyrie: 0.2-Dev-8
Red Core: 0.4-Dev-5
ConfigAnytime: 1.0
MixinBooter: 8.4
RenderLib: 1.3.3
Forge: 1.12.2 - 14.23.5.2860
Java: 1.8.0-382
Java JVM: Bellsoft Liberica

Specification:

OS: Windows 11
CPU: Ryzen 5 5600g
GPU: Radeon RX 570 4gb OC
RAM Allocated: 4096mb

Desoroxxx commented 1 year ago

Yeah latest RenderLib causes incompatibilities I will fix it this week, but reverting to a slightly older renderlib is completly fine in the meanwhile the changes where mainly on the debug side of things iirc

Xisdar commented 1 year ago

I may have had a similar problem. Also Valkyrie and RenderLib in the assembly When disabling Valkyrie the problem disappeared. Pack of mods for optimization are used from here Here was a problem with minixes Although it is not explicitly stated that Valkyrie and RenderLib are to blame.

Desoroxxx commented 1 year ago

Just use the workaround said here:

reverting to a slightly older renderlib is completly fine in the meanwhile the changes where mainly on the debug side of things iirc

ChromaPIE commented 11 months ago

any follow up on this issue?

Desoroxxx commented 11 months ago

any follow up on this issue?

I need to work on it probably next dev build, currently going around my mod doing huge quality of life improvement internally

KnightCa commented 10 months ago

Using RenderLib version 1.3.2 works for now (one version older from most recent).

Sounds like a full compatibility is in development for version 1.3.3.

Natedogwoooof commented 8 months ago

still crashes btw

Desoroxxx commented 8 months ago

still crashes btw

I know under a lot of work right now, trying to get things done, sorry for the wait