search

Red-Studio-Ragnarok / Valkyrie

As the Valkyries' whispers guide us, we carve our path to a Valhalla of optimized Minecraft gameplay.
MIT License
20 stars 4 forks source link

Bigger Atlas fix doesn't work when Modern Splash is present #24

Closed xJon closed 1 year ago

xJon commented 1 year ago

As the title states, I guess there's a conflict there.

Desoroxxx commented 1 year ago

We talked about the issue on Discord already, but it is an issue on Modern Splash side as it overrides the entirety of the splash class, Mixin should be used instead @kappa-maintainer

kappa-maintainer commented 1 year ago

Please test this build You need to change .zip to .jar before use modernsplash-1.12.2-1.3.zip

Desoroxxx commented 1 year ago

Please test this build You need to change .zip to .jar before use modernsplash-1.12.2-1.3.zip

Is this using Mixin instead of replacing the splash class or is it just reimplementing the fix into your class?

xJon commented 1 year ago

@Desoroxxx It's just reimplementing the fix.