search

Red-Studio-Ragnarok / Valkyrie

As the Valkyries' whispers guide us, we carve our path to a Valhalla of optimized Minecraft gameplay.
MIT License
20 stars 3 forks source link

Incompatibility between Valkyrie's precise depth buffer option and Weather mod #33

Closed ninjakitty844 closed 10 months ago

ninjakitty844 commented 11 months ago

Describe the bug

Weather mod changes how Valkyrie's depth buffer works, and can make your hand able to go through blocks.

Weather mod: https://www.curseforge.com/minecraft/mc-mods/weather-storms-tornadoes Requires CoroUtil as dependency: https://www.curseforge.com/minecraft/mc-mods/coroutil

By default settings, Weather mod just kinda disables Valkyrie's depth buffer. You can get Valkyrie's depth buffer working again by disabling Weather mod's "useEntityRenderHookForShaders" option (in config/CoroUtil/General.cfg), however this will then make your hand able to clip through blocks.

Currently you cant have both precise depth buffer from Valkyrie AND correct hand rendering at the same time, if you are using Weather mod as well.

This is all kind of a mess, but if there is a way to fix this issue from Valkyrie's side somehow, that would be very nice. Maybe if its possible to mixin to Weather mod's code and override the part where it essentially duplicates and forces usage of whatever Minecraft rendering code was lacking a depth buffer? I don't have a good understanding of how this would work, I just really think Weather mod would require depth buffer to look good, the way raindrops immediately become dark blue when over (not under) water breaks immersion a bit :[

Reproducibility

To Reproduce

Steps to reproduce the behavior:

  1. Install Valkyrie
  2. Turn on depth buffer option in Valkyrie's config
  3. Notice that depth buffer is nice TM
  4. Install Weather mod
  5. Notice that your hand clips through blocks now
  6. Turn off "useEntityRenderHookForShaders" in config/CoroUtil/General.cfg
  7. Notice that your hand no longer clips through blocks, but now Valkyrie's depth buffer option is non-functional and is doing nothing

Expected behavior

Functional depth buffer from Valkyrie, without hand clipping. And with Weather mod still installed.

Screenshots or/and videos

Clipping hand: 2023-10-06_02 36 15

Not clipping hand: 2023-10-06_02 36 39

(these images are taken from the exact same position and rotation)

Versions

ninjakitty844 commented 10 months ago

Update: this bug actually isn't because of Valkyrie at all and "useEntityRenderHookForShaders" from Weather mod is broken whether Valkyrie is installed or not.

I reported the bug to the Weather mod GitHub a while ago but forgot to close this report until now.