Closed Meldexun closed 6 months ago
This update brings a more flexible and configurable approach to customizing the Minecraft client, particularly in how the window title and depth buffer settings are managed. By shifting from a direct overwrite to utilizing Mixin annotations like @ModifyConstant
, the modification process becomes less intrusive and more adaptable to different configurations, enhancing the mod's compatibility and ease of use.
File Path | Change Summary |
---|---|
.../valkyrie/mixin/MinecraftMixin.java |
Refactored createDisplay method to use @ModifyConstant for window title and depth buffer customization. |
🐇✨
In the realm of code, where the bits entwine,
A rabbit hopped through, leaving changes so fine.
With a flick and a tweak, in the Java domain,
It danced through the mixins, a new elegance to claim.
"To improve, to enhance!" it cheerfully sings,
Leaving behind, in the code, its whimsical springs.
🌟🐰
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
📝 Description
Replaces the mixin that overwrites the
Minecraft#createDisplay
method with two ModifyConstant mixins to fix compatibility with RenderLib 1.3.3+.🎯 Goals
Fix compatibility with RenderLib 1.3.3+.
❌ Non Goals
Change any Valkyrie functionality or introduce new bugs.
🚦 Testing
Couldn't create a Valkyrie build and thus just created a test mod with the new ModifyConstant mixins.
⏮️ Backwards Compatibility
PR is backward compatible.
📚 Related Issues & Documents
23
🖼️ Screenshots/Recordings
None
📖 Added to documentation?
😄 [optional] What gif best describes this PR or how it makes you feel?
😶
Summary by CodeRabbit