coderabbitai[bot]
commented
5 months ago Walkthrough
The update introduces a new feature to the Valkyrie project, allowing users to control the rendering of clouds based on the world's dimension. It adds configuration options to specify dimensions where clouds should be shown or hidden, enhancing customization for different game environments. This is achieved by introducing a dimension list and a blacklist flag in the configuration, along with logic in the cloud renderer to apply these settings.
Changes
| File Path | Change Summary |
|---|---|
.../config/ValkyrieConfig.java |
Added dimensionList and dimensionListIsBlacklist to CloudsConfig. |
.../renderer/CloudRenderer.java |
Updated updateSettings() to include dimension list logic. |
.../assets/valkyrie/lang/en_us.lang |
Added new cloud graphics configuration options. |
🐰✨
Over the hills, under the sky so vast,
Clouds dance freely, as dimensions pass.
In realms where Valkyries dare to tread,
New rules in place, by clever minds led.
🌥️🚫🌍
So hop with joy, for now, we choose,
Where clouds may roam, or take their snooze.
🐇💻🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Desoroxxx
📝 Description
This PR adds configuration that allows players and modpack makers to specify a list of dimensions where Cloud Rendering is enabled (whitelist) or not enabled (blacklist), by writing a list of dimension IDs and if such list is a blacklist or a whitelist, in mod configuration. Config is reloadable (no MC restart or World Reload required). Config are also localized, in line with the other config options
🎯 Goals
Enhance mod configurability and customizability
❌ Non Goals
The PR aims to limit where could can render, instead of adding cloud rendering to more dimensions. For example, this PR allows players to disable Clouds in The Overworld but not in Twilight Forest. Before this PR one could only enable or disable cloud rendering for both at the same time. This PR does not allow one to add clouds to The Nether or The End.
🚦 Testing
Tested in both dev environment and custom modpack (500+ mods)
⏮️ Backwards Compatibility
This chance is Backwards compatible. By default, the dimension list is an empty blacklist. Configuration still obeys to master switch "enable clouds", and players that update the mod without knowing this change, will not experience any change whatsoever
📚 Related Issues & Documents
None that I know of
🖼️ Screenshots/Recordings
Nothing to show, just new configs
📖 Added to documentation?
😄 [optional] What gif best describes this PR or how it makes you feel?
Advanced Rocketry planets with clouds: 🤮
Summary by CodeRabbit