Icon and window title conflict with `RandomPatches`

[Krutoy242]

Describe the bug

I have RandomPatches installed.

1. Even if Valkyrie config customIcons=false, window icon is still resetted to default, despite being setted in RT configs.

   In other words, RT window icon config working fine, but when i add Valkyrie into modpack, it stop working. I expect that disabled config options should not prevent other mods to change same configuration.

2. Window title working as opposite - even if i have window title setted up in Valkyrie, its just empty. But if i go to game menu and change window title here, its appear again.

   It feels like window title controlled by RT on game loading, but controlled by Valkyrie on config change event.

This how it should looks like when everything fine:

Logs or/and crash reports

https://mclo.gs/qLSY8j2

Specification:

• OS: Windows 10

Additional context

Happens on E2E-E modpack.

[Desoroxxx]

RandomPatches has a brutal way of implementing patches to the Minecraft class, it causes incompatibilities with anything else that touches it.

Recommandation is that you should not use RandomPatches and instead use alternatives like Universal Tweaks and others.

[Krutoy242]

😕

[Desoroxxx]

😕

Sadly there is literally nothing that one can do, oh I forgot, actually you can do something, if you disable patching of the Minecraft class in RandomPatches config it will just work.

Keep in mind Universal Tweaks does everything RandomPatches do but better, so I would strongly recommend switching to it, although I am not sure if UTweaks implemented everything in RandomPatches yet, if you depend on a missing feature you can probably do a suggestion.

[Krutoy242]

if you disable patching of the Minecraft class in RandomPatches config it will just work.

Now we talking! Thanks for the suggestion, I will try that.

strongly recommend switching to it

Im already have it, but RT have few features that i need like removePotionGlint that isnt implemented in UT.

[Krutoy242]

No, disabling patchMinecraftClass not helping with window name issue.

[Krutoy242]

Ok, seems like its not incompat issue with Random Patches. Since I disabled RT jar file and still see wrong window name

Should i create new issue?

https://mclo.gs/PuUMNTB

[jchung01]

In the case of a Cleanroom environment, Fugue has temporarily disabled Valkyrie's window title modification until Desoroxx fixes it because it caused mixin crashes.

[Krutoy242]

Then, @Desoroxxx please add config to disable icon/title changing so i could fully use this feature from RandomPatches.

[Krutoy242]

add config to disable icon/title changing

I could make another issue with this feature request if you don't mind.

[Desoroxxx]

add config to disable icon/title changing

I could make another issue with this feature request if you don't mind.

This wouldn't fix RandomPatches issues, the issue how is how it applies it's changes, but I will fix the issues with Cleanroom soon