search

Red5d / pushbullet-bash

Bash interface to the PushBullet API
236 stars 41 forks source link

allow other curl options #79

Closed r2evans closed 7 years ago

r2evans commented 7 years ago

In a DD-WRT environment, I don't always have the ability to set the CA certificates for connecting to secure websites. The right answer is to add certs so that curl will verify correctly. A hack can be to allow --insecure, at least for testing. By setting CURL="curl --insecure" at the top of this patch (or an addition for --cacerts), it works as anticipated.

This patch does not require the "POSIX" patch but I'm using them combined for the purposes of running on my DD-WRT router.

r2evans commented 7 years ago

@Red5d @fbartels, do you know what the intent is for maintaining pushbullet-bash? There has been one commit in the last year (in the readme), your last commit was a year ago, and there's not been a lot of other activity on it. (Likewise, not a lot of "issues" either, which could be a good sign.)

I'm not rushing or trying to take over, I just don't want to find out in six months that it's terminal on the back-burner with no intention for active development.

Thanks to @Red5d and you, btw: I like the tool and use it all the time (as my involvement suggest).

Red5d commented 7 years ago

I've been kinda busy the past few days, but I'm going to try and finish and merge your contributions shortly.

There hasn't been a lot of activity on this tool mostly because it hasn't been needed apart from bugfixes and some adjustments a while back to address api changes and implement newly-available features.

@fbartels , if you're interested, I'll add you as a collaborator on this repo so you can help review/merge pull requests. You already help out in the Issues and looking over code in pull requests (which is much appreciated).

r2evans commented 7 years ago

Thanks for the prompt feedback. I had hoped the slow rate of change was due more to relative stability. (I'm also surprised that PB hasn't changed their API much in the last year.) Let me know what I can do.

fbartels commented 7 years ago

@Red5d hi, sorry I'm on vacation and only saw your comment now. I'll gladly take the higher repo permissions. Already have bookmarked these issues for some further testing once I'm back.

Red5d commented 7 years ago

@fbartels , great, thanks! I've added you and apparently there's a link that's been emailed to you which you'll have to click on to accept it.