search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 408 forks source link

add JpegQuality parameter #125

Closed alaeri closed 7 years ago

alaeri commented 7 years ago

I added a jpegQuality parameter.

I copied what was done with sensorSensitivity (except the selector, not needed here as jpegQuality is an int ranging from 0 to 100 for camera Api). I think I've set the default compression value to 95, I'm not sure I have understood everything about what I did as I was in a hurry. I tried to follow existing format conventions as I was doing it.

I integrated it to the sample and I have tested it with Camera1 (not tested with Camera2 yet)

Diolor commented 7 years ago

Hey @alaeri totally awesome you made this PR! I added few minor notes. Would be nice to have those fixed. I would also be nice to have a QA on this before merging but I don't have time rn to do

alaeri commented 7 years ago

Hey @Diolor
Very glad you like the PR 👍

I can't see the notes you added. What kind of QA can I do to help?

dmitry-zaitsev commented 7 years ago

Thanks for your effort! This will go into the next release.

alaeri commented 7 years ago

Thank you. That's great news!