Update selectors validation

Diolor commented 6 years ago

This is a bugfix by comments by @jpribble in #143 : Fix range validation & allow null value for fps range & iso.

Alternatively we could always set one, however reason to allow null over force value:

FPS range list could be empty, so 🤷‍♂️. (I have not validated this, I see the selector created by @friendoye)
ISO should be better to be left untouched by FA by default. Hardware manufactures could be smarter than us and select the correct ISO and avoid issue like #139. Or range could simply be null (I see @JPLITPeople's selector which returns null if list is empty in the #139).

If lists are ensured to always contain a value then we could discuss to have a default value and not allow nulls

friendoye commented 6 years ago

I'm not sure, but getSupportedFpsRange always returns non-empty list with int[] (at least, for Camera API 1). Also some phones allow you to set ISO parameter to "auto".

GrishmaPromact commented 6 years ago

@Diolor ohk. Thanks.

Diolor commented 6 years ago

I will close this as it has been fixed in v2.0

RedApparat / Fotoapparat

Update selectors validation #145