search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 405 forks source link

Minimum API version changed from 14 to 16 #173

Closed bernatpl closed 6 years ago

bernatpl commented 6 years ago

Hello,

I found out that the minimum API version changed from 14 to 16. (https://github.com/Fotoapparat/Fotoapparat/commit/2ac387d6ff77caca6b7f5dd9799e17cd5c3c7f57) I must support at least API 15, so it blocks me to use the latest features and bug fixes in newer versions. I didn't see this change documented anywhere. It would be good to document it at least on the release notes. I tried to build the library using the minimum API as 14 And the sample application works perfectly. I'm wondering if it was really necessary to change from minimum API 14 to 16.

Thanks!

Diolor commented 6 years ago

Hey. That was an accidental change actually. We can revert to 14. If you happen make a PR we can quickly make a 2.1.2 patch version

bernatpl commented 6 years ago

Pull request #174 passed all the checks.

bernatpl commented 6 years ago

Thank you very much for fixing it so fast! You're doing a great job here! :)

Diolor commented 6 years ago

❤️
Thanks for the PR!