RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 405 forks source link

performClick was lost =) #220

Closed scifinder closed 6 years ago

scifinder commented 6 years ago

Hello! =) I decided to implement the zoom with gestures. On my construction cameraView.setOnTouchListener(new View.OnTouchListener() { ... I receive a warning:

Custom view "CameraView" has setOnTouchListener called on it but does not override performClick.

I tried to extend the class CameraView so to add @Override performClick(...), but I get error like "final class can not be overridden". Can you add it on you source? =)

Diolor commented 6 years ago

We would be happy to accept a PR!

scifinder commented 6 years ago

I'm not sure, but I think something needs to be done in CameraView class:

override fun performClick(): Boolean {
    return super.performClick()
}

in CameraView and FocusView

dmitry-zaitsev commented 6 years ago

@scifinder you can safely ignore this warning - it does not really point at any real issues in the implementation. Thanks for reporting though 👍