search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 405 forks source link

White balance #227

Open savviestapps opened 6 years ago

savviestapps commented 6 years ago

Sorry if Im way out of line here, but I can't find a discussion group for this.

What are you trying to achieve?

I'd like to use this library and set White Balance in the preview and saved image. I'd like to be able to set custom white balance as well as the enumerated options available in the Camera2 library. Im using Java language

I was hoping to find something in the CameraConfiguration class but no luck. Is there a way to get access to the underlying camera/surface objects to set white balance somehow?

Thanks

Diolor commented 6 years ago

Hey! This feature doesn't exist. But if you like send a PR! Pattern is quite similar for all attrs.

[Docs for camera 1](https://developer.android.com/reference/android/hardware/Camera.Parameters.html#getWhiteBalance())

savviestapps commented 6 years ago

Sorry, whats a PR? Does this mean I can somehow get hold of a Camera object from a Fotoapparat or cameraView object and go to work on it?

It looks like I can maybe do a call like fotoapparat.getCurrentParameters() but Im stumbling on the java code a bit. Any pointers?

dmitry-zaitsev commented 6 years ago

@savviestapps PR stands for Pull Request. @Diolor was proposing you to fork the GitHub repository and make all the changes yourself. If you are not confident about doing that - no worries, we will get to this feature as soon as we'll have time.

esafirm commented 5 years ago

Hey @Diolor @dmitry-zaitsev can i take this? So i think i just have to add white balance option to CameraConfiguration?