Closed Raenar4k closed 6 years ago
What's your previewResolution
in pixels?
It is 1600x1200 (1600 width, 1200 height) in both FA 1.4 and 2.2 for Nexus 5x Im using fotoapparat sample apps from these commits (updated description at top): 9a8bbb10214acabdd3b60db21e6a093045d38986 - 2.2 21652d836e783c99e417465353366c14a52ff769 - 1.4
@Diolor Is there anything i can help with? I'm not sure what could have caused it and v2 had a lot of changes.
@Raenar4k just an assumption, but it might be related to the size of the camera viewport. As you can see in v1 we had a toolbar which reduced the size of the CameraView
which in turn possibly affected the image resolution.
Can you try to reduce the size of the CameraView
and tell us if there is any noticeable difference?
I am closing this until more information is provided.
@dmitry-zaitsev Sorry for long reply, finally got to test this. I've tried same style with toolbar as in 1.4.1 for sample project - and effect is still there. In my app layout was not changed when migrating to 2.0, so i'm sure that was not the reason.
Also i've not seen this in other devices for now.
What are you trying to achieve or the steps to reproduce?
There are noticeable stair-steps and pixelation in preview at version 2.2 of FA. I've managed to reproduce it only on Nexus 5x and Google Pixel 1 gen, not sure if other devices are affected. When using version pre 2.0 like 1.4 this effect does not appear (noticed only after migration).
I've attached a video with comparison of FA 1.4 and FA 2.2 sample apps. (Gif big enough too see details was about 100mb, so i've uploaded zip with mp4 here) sharp_edges.mp4.zip
It is noticeable when you are using the app and better viewed in video above, but you can see jagged lines even on this screenshot (pixelation barely visible though)![comparison](https://user-images.githubusercontent.com/13849790/37514414-ecb893dc-2918-11e8-9142-c3cfb9893fcf.png)
How did you initialize FA?
It is sample app from FA version 1.4 and version 2.2 from these commits: 9a8bbb10214acabdd3b60db21e6a093045d38986 - 2.2 21652d836e783c99e417465353366c14a52ff769 - 1.4
Context: