search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 405 forks source link

Change permission requirements #229

Closed MonikaOlkowska closed 6 years ago

MonikaOlkowska commented 6 years ago

Is there a chance to merge this pull request? Now is impossible to use Fotoapparat on chromebooks

Diolor commented 6 years ago

Chromebooks have no camera permission? Secondly why use a camera lib if it's optional?

dmitry-zaitsev commented 6 years ago

@MonikaOlkowska I believe that just adding <uses-feature> would be sufficient to make it run on Chromebook. So, removal of the <uses-permission> is not needed.

Because of that, I am closing this Pull Request. I might still be wrong - in that case please let me know and we'll try to solve the problem.