search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 407 forks source link

Updated Coroutines #306

Closed PaulWoitaschek closed 5 years ago

PaulWoitaschek commented 5 years ago

Else it's not compatible with Coroutines 0.30.2 and proguard will fail with a

Warning: io.fotoapparat.coroutines.AwaitBroadcastChannel: can't find referenced method 'kotlinx.coroutines.experimental.DisposableHandle attachChild(kotlinx.coroutines.experimental.Job)' in program class kotlinx.coroutines.experimental.CompletableDeferred
PaulWoitaschek commented 5 years ago

@dmitry-zaitsev @Diolor Could you review this? Fotoapparat currently forces one to not upgrade the coroutines library as it's incompatible with 0.30.2

dmitry-zaitsev commented 5 years ago

Will take a look at it tomorrow (10.10).

Thanks for fixing it!

On Tue, 9 Oct 2018, 20:41 Paul Woitaschek, notifications@github.com wrote:

@dmitry-zaitsev https://github.com/dmitry-zaitsev @Diolor https://github.com/Diolor Could you review this? Fotoapparat currently forces one to not upgrade the coroutines library as it's incompatible with 0.30.2

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/RedApparat/Fotoapparat/pull/306#issuecomment-428304475, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2igsn4K2CmE-j1Pu05Yep8OqthDf9Qks5ujO3XgaJpZM4XNi7B .