RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.81k stars 405 forks source link

Set source and target compatibility to Java 1.8 for library and dependencies #343

Closed wolf81 closed 5 years ago

wolf81 commented 5 years ago

I've created a C# binding library for Fotoapparat so I'm able to use it in a Xamarin based Android app.

One of the issues I encountered was that source code could not properly be desugared, the reason being that the source and target compatibility was not set. In this PR I've set the source and target compatibility to 1.8 for both the Fotoapparat library as well as the rxjava* dependencies (though perhaps it's not really needed for rxjava, I was thinking it couldn't harm).

Diolor commented 5 years ago

Hey! Sorry for the late reply. Making java 8 should be okay, so I will merge this, thanks