Add ability to specify sensor sensitivity (aka ISO)

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸

Apache License 2.0

3.82k stars 408 forks source link

Add ability to specify sensor sensitivity (aka ISO) #35

Closed hagabaka closed 7 years ago

hagabaka commented 7 years ago

Part of #21

dmitry-zaitsev commented 7 years ago

Thanks! I finish the review tomorrow.

There are things which are different from our writing style (which is, to be fair, not documented anywhere yet), they will need to be changed before we can merge it. I don't expect you to fix any of them, we can do it ourselves as well :)

Diolor commented 7 years ago

Thanks for the PR! I think most of the comments are quite straight forward and no architectural changes are needed. We can easily work on resolving them 👍 Maybe more test can be added, will check as soon as I check the code in my AS.

Diolor commented 7 years ago

Fixes #38

hagabaka commented 7 years ago

I've been busy with other projects. It might take two more weeks before I can work on this again.

Diolor commented 7 years ago

Thanks @hagabaka ! Will close this since this work was merged with #87