search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.81k stars 405 forks source link

Find a bug in picture/preview resolution #356

Closed mym0404 closed 3 months ago

mym0404 commented 5 years ago

I used updateConfiguartion method with change pictureResolution attribute. I found updating pictureResolution affects previewResolution.

I Changed In CameraParameterProvider.kt,

val selectedPictureResolution = pictureResolution selectFrom pictureResolutions val validPreviewSizeSelector = validPreviewSizeSelector( resolution = selectedPictureResolution, original = previewResolution )

to

val selectedPictureResolution = pictureResolution selectFrom pictureResolutions val selectedPreviewResolution = previewResolution selectFrom previewResolutions val validPreviewSizeSelector = validPreviewSizeSelector( resolution = selectedPreviewResolution, original = previewResolution )

Very thank you to making library.