search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 407 forks source link

photoResult not full view in imageview #64

Closed faketon closed 7 years ago

faketon commented 7 years ago

photoResult not full view in imageview what i miss ?

i try to setScaleType in imageview but not work. can you explane me what i miss ?

faketon commented 7 years ago

But i use Glide to help load image from path file. it can full view. But i want to know this lib can help or not. Thank you for lib

Diolor commented 7 years ago

This library has nothing to do with loading images to an imageview. Please see https://developer.android.com/reference/android/widget/ImageView.ScaleType.html

bruferrari commented 7 years ago

@Diolor I also have this problem and even using scaleType it does not fit the entire screen, I also had changed the sample and can't achieve the expected results.

dmitry-zaitsev commented 7 years ago

@faketon @bruferrari could you please provide screenshots for the problem? It would be easier to understand what the problem is.

bruferrari commented 7 years ago

Hi @dmitry-zaitsev here are some pics to better describe the mentioned problem, note that with any kind of scaleType that I'd used the image does not goes beyond that limit and I have the CameraView with width and height in match_parent.

Please do not pay so much attention on that odd floating FAB, I was trying everything to solve the problem even swap between ConstraintLayout to FrameLayout in order to note some changes but without success.

screenshot_20170731-181804 scaleType="fitXY"

1501535879661 original photo saved

screenshot_20170731-183046 without scale type

faketon commented 7 years ago

i fix my problem by use glide to load image from path. if you use bitmap from photoResult to set in imageview that photo can't full view. @bruferrari that is my resovled

dmitry-zaitsev commented 7 years ago

Note that in sample app we are using scaled () when taking a photo. Removing that should solve your problem.