search

RedApparat / Fotoapparat

Making Camera for Android more friendly. 📸
Apache License 2.0
3.82k stars 406 forks source link

Customize preview FPS range #83

Closed friendoye closed 7 years ago

friendoye commented 7 years ago

Ping! @dmitry-zaitsev

dmitry-zaitsev commented 7 years ago

@friendoye hi, sorry - very packed week :) I answered your comments now.

friendoye commented 7 years ago

Thanks for the response! I will fix your comments in a day or two.

friendoye commented 7 years ago

I worked on your comments and I think they are fixed. I'm still uncertain with replacing ContinuousRange instance creation with factory method, so let me know is it okay.

dmitry-zaitsev commented 7 years ago

@friendoye thanks! I'll take a look at them this Saturday.

dmitry-zaitsev commented 7 years ago

@friendoye looks good 👍

There is a merge conflict though. As soon as it is fixed (assuming that our CI is happy with changes) I will merge this PR.

dmitry-zaitsev commented 7 years ago

@friendoye thanks for the contribution! 👍