RedBrumbler / Quest-BSML

Beatsaber markup language repository for Quest
8 stars 5 forks source link

Feat: SetImage onFinished success bool to catch errors #103

Closed FrozenAlex closed 1 year ago

FrozenAlex commented 1 year ago

To have some sort of way to know if loading an image failed I need a success boolean from onFinished callback

The code in question https://github.com/RedBrumbler/Quest-BSML/commit/498225ded21d3db4c1e8e6f9d6d45657fbb49197#diff-69c070bacc4b2ff0741daaa1a83e9e9760268a95913f9a4689ce77a0f5249734R301

RedBrumbler commented 1 year ago

This is handled in #123 where there's a callback you can use that gets called on error, this just needs to be tested before it can be merged properly... preferably something like nya or imagefactory using this and getting an ok that it works right would be great :D

RedBrumbler commented 1 year ago

can be closed when #123 is merged

RedBrumbler commented 1 year ago

released in v0.3.0