search

RedBrumbler / SongBrowser

Quest port of the PC songbrowser mod
9 stars 6 forks source link

Initial bringup to 1.21.0 #10

Closed JonnyVR1 closed 2 years ago

JonnyVR1 commented 2 years ago

There are still some things that don't work - I don't fully understand C++ as I'm a C# dev. The remaining issues should be fairly quick to solve for someone who knows what they're doing though!

My main issue atm is that level->get_levelID() seems to cause a crash and I have no idea why so I can't really progress any further.

JonnyVR1 commented 2 years ago

Fixed the level->get_levelID() crash, now the issue is that when filtering (e.g. FilterOriginal method) we get cannot find method errors in ArrayUtil.cpp, despite the methods/fields being present in codegen List implementation.

RedBrumbler commented 2 years ago

I'm missing the CMakeLists.txt file, I think that ties into why ID is needed instead of what is now used (MOD_ID)

JonnyVR1 commented 2 years ago

I'm missing the CMakeLists.txt file, I think that ties into why ID is needed instead of what is now used (MOD_ID)

In that case then this isn't in the remit of this PR to fix. CMakeLists.txt is needed to even get the project loaded in CLion. The include is needed whether or not CMakeLists.txt is present.

JonnyVR1 commented 2 years ago

Switched to MOD_ID

Christoffyw commented 2 years ago

The powershell scripts are outdated. They are still using Android.mk

RedBrumbler commented 2 years ago

ahhh that must be why it wasn't properly building n stuff

JonnyVR1 commented 2 years ago

The powershell scripts are outdated. They are still using Android.mk

Outside of the remit of this PR

JonnyVR1 commented 2 years ago

For funsies I've updated the build setup to the new standard, even though it was outside of the remit of this PR. cba arguing about this in the comments so just easier to update it.

RedBrumbler commented 2 years ago

ahhh yea I guess in technicality it's outside the PR but all the tooling uses that now so it would be harder not to do that