RedDot-3ND7355 / BnS-Buddy

Improve your Blade & Soul Gaming experience.
https://www.bnsbuddy.com
45 stars 22 forks source link

Feature request: Bitness-agnostic addons #7

Closed alexrp closed 6 years ago

alexrp commented 7 years ago

Hello,

I've been writing a few addons to make my life easier whenever a new patch is deployed. One thing that results in a lot of repetition, though, is the fact that I have to write two separate files for the 32-bit and 64-bit client. For example, to disable Nagle in arena for both 32-bit and 64-bit, I need these files:

FileName = config64.dat.files\\system.config2.xml
Search = <option name="use-nagle-arena" value="true" />
Replace = <option name="use-nagle-arena" value="false" />
Description = Disable Nagle's algorithm in arena (64-bit)
FileName = config.dat.files\\system.config2.xml
Search = <option name="use-nagle-arena" value="true" />
Replace = <option name="use-nagle-arena" value="false" />
Description = Disable Nagle's algorithm in arena (32-bit)

I'm wondering if a special variable, e.g. ${bits}, could be introduced, so I could just write a single file like this:

FileName = config${bits}.dat.files\\system.config2.xml
Search = <option name="use-nagle-arena" value="true" />
Replace = <option name="use-nagle-arena" value="false" />
Description = Disable Nagle's algorithm in arena

When BnS Buddy sees that an addon uses ${bits} in its FileName component, it would know that this addon should be applied to both 32-bit and 64-bit clients. When applying it to the 64-bit client, ${bits} would be replaced with 64, and for the 32-bit client, it would just be replaced with the empty string, so the above would expand to config64.dat.files\\system.config2.xml and config.dat.files\\system.config2.xml.

Would this be feasible to implement?

RedDot-3ND7355 commented 7 years ago

Sadly I won't implement this. The reason why is that you don't need don't need to do both to play the game. only 1. wich is depending on the client you decide to play with.

But I sure do understand, it's to save user time and not having to create two patches or ticking 2 boxes.