Script formating and optimization

RedEM-RP / redem_roleplay

RedEM Roleplay Framework

https://discord.gg/nbmTmZR

Other

61 stars 51 forks source link

Script formating and optimization #43

Closed Pauljoych closed 2 years ago

Pauljoych commented 2 years ago

Formating LUA with Lua
Adding LUA 5.4 to fxmanifest.lua.
Changing logic to get array length.
Changing array check from ~= to not
Changing inconsistency callback function function to "cb"

abdulkadiraktas commented 2 years ago

I couldn't see any code that would affect the optimization. The pull request you sent is far from readable. My suggestion is to send edit and optimized changes separately as pull requests. Also, I didn't understand the purpose of changing the variable "_source" to "src".

Pauljoych commented 2 years ago

I couldn't see any code that would affect the optimization. The pull request you sent is far from readable. My suggestion is to send edit and optimized changes separately as pull requests. Also, I didn't understand the purpose of changing the variable "_source" to "src".

Okay let me separate per point as a new PR.