RedGuides / MQ2AutoForage

Configurable foraging
https://www.redguides.com/community/resources/mq2autoforage.99/
0 stars 0 forks source link

Deprecations - [merged] #4

Closed Redbot closed 10 months ago

Redbot commented 1 year ago

In GitLab by @Sicprofundus on Dec 18, 2022, 14:37

Merges deprecations -> master

Redbot commented 1 year ago

In GitLab by @Knightly1 on Dec 29, 2022, 16:33

approved this merge request

Redbot commented 1 year ago

In GitLab by @Knightly1 on Dec 29, 2022, 16:33

mentioned in commit 3e4aa4280cbe954d4a1bce9578839aa5a6f98639

Redbot commented 1 year ago

In GitLab by @brainiac on Dec 29, 2022, 17:14

Commented on MQ2AutoForage.cpp line 249

missed one. can just be if (pLocalPlayer)

Redbot commented 1 year ago

In GitLab by @brainiac on Dec 29, 2022, 17:14

Commented on MQ2AutoForage.cpp line 294

can just be if (pLocalPlayer)

Redbot commented 1 year ago

In GitLab by @brainiac on Dec 29, 2022, 17:15

Commented on MQ2AutoForage.cpp line 299

if (ItemDefinition* pCursor = pCont->GetItemDefinition())

Redbot commented 1 year ago

In GitLab by @brainiac on Dec 29, 2022, 17:15

Commented on MQ2AutoForage.cpp line 302

this code doesn't even need szItem in the first place

Redbot commented 1 year ago

In GitLab by @brainiac on Dec 29, 2022, 17:16

Commented on MQ2AutoForage.cpp line 132

This variable has no purpose anymore. usages of pChSpawn can simply be replaced with pLocalPlayer.

Redbot commented 1 year ago

In GitLab by @Sicprofundus on Dec 29, 2022, 18:23

resolved all threads