search

RedGuides / MQ2Melee

Automate melee skills & movement
https://www.redguides.com/community/resources/mq2melee.287/
0 stars 0 forks source link

LS Update - [opened] #9

Open Redbot opened 11 months ago

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 10:53

Merges master -> master

Added remaining spells/discs for LS, updated potion list, corrected some older spell/disc entries

Redbot commented 11 months ago

In GitLab by @Sicprofundus on Dec 16, 2023, 11:13

Commented on MQ2Melee.cpp line 600

these are examples of the things i pointed out where this changes behavior.

Focused line is single target vs tempest of blades is aoe

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 11:28

Commented on MQ2Melee.cpp line 600

I noticed that but wasnt quite sure what to do with it when I updated it so just continued the existing broken trend. TBH should probably be split off on a new ability but I imagine they share a timer which complicates things a bit. Will add it to the to do list. There was a few other things I noticed and want to update also.

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 12:10

Commented on MQ2Melee.cpp line 600

On retrospect an either/or or neither option probably work the best. That or a general enable aoe abilities option.

Redbot commented 11 months ago

In GitLab by @Sicprofundus on Dec 16, 2023, 13:01

Yep, and there are some mixes of +aggro and -aggro if I remember correctly - things that share timers

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 13:15

Like Brainy is found of saying, people use allot of old macros that depend on this stuff so removing/not maintaining them causes allot of issues. Having your toon use 2-3 expansions old discs isnt very useful either. This will at least update the disc usage and wont cause any problems that arnt already occurring. Next update I will split the lists into AoE/non-AoE. Will look for the aggro issue ones, didnt notice those but not familiar with all of the different classes. Will deactivate the aoe ones until I can fix the rest of the code to provide options for aoe vs non but at least will fix the issue for now. At least its progress imo.

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 21:27

Commented on MQ2Melee.cpp line 600

changed this line in version 2 of the diff

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 21:27

added 1 commit

Compare with previous version

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 21:30

Split out rng aoe blades from the focused and the focused bst claws from the aoe. Ability for bst seems to be mostly an aoe ability. Will have to enable them at a later date but fixes the alternating aoe/single issue. If there are any others I am unfamiliar with them. Didnt notice any aoe/single aggro mixes.

Redbot commented 11 months ago

In GitLab by @FelisMalum on Dec 16, 2023, 21:30

resolved all threads