search

RedHat-Israel / ROSE

ROSE project car race game
GNU General Public License v2.0
34 stars 121 forks source link

Ci #446

Closed didib closed 2 years ago

nirs commented 2 years ago

I tried to use pipeenv but it is horribly slow for CI so I added simple requirments.txt files.

We can squash and merge to have working CI.

@didib what do you think?

didib commented 2 years ago

I tried to use pipeenv but it is horribly slow for CI so I added simple requirments.txt files.

We can squash and merge to have working CI.

@didib what do you think?

OK for me.

For Nitzanim project last week, I did this on my own fork, and also guided my mentees do use their own fork.

Now that this week is over and we most likely have some time til the next use of current project, perhaps we can clean up everything including CI to use pipenv, but that's not mandatory - we can also do this later after merging and enabling CI.

nirs commented 2 years ago

I think we should get rid of pipenv and use containers for CI, maybe also for development. We have only 2 requirements (twisted, autobhan) and installing them using pip or distro packages is easy.