search

RedHat-Israel / ROSE

ROSE project car race game
GNU General Public License v2.0
34 stars 121 forks source link

Explictly test for players car in lane #477

Closed yaacov closed 10 months ago

yaacov commented 11 months ago

Issue: When testing if a car is in lane, we do an implicit test, calculating the start and end x value of the player lane, it's better to use explicit calculation to get the lane directly from car position.

yaacov commented 11 months ago

@nirs @sleviim hi, can you review / refer to a reviewer ?

nirs commented 10 months ago

Issue: When testing if a car is in lane, we do an implicit test, calculating the start and end x value of the player lane, it's better to use explicit calculation to get the lane directly from car position.

Not clear to me why the current code is implicit and the new code is explicit. I think both are the same in this aspect.