RedHat-Middleware-Workshops / dg8-workshop

Source for the Red Hat Data Grid 8.0 workshop content repository
15 stars 22 forks source link

update minor things along with Quarkus Stack and improve contents #16

Closed danieloh30 closed 4 years ago

danieloh30 commented 4 years ago

The reason why I removed the comment(i.e. // TODO:) in copy-paste widget and add it in the instruction, I think it not only encourages attendees to read/understand the instruction first(b/c they need to know where this codes should be replaced/added) but also avoids to duplicate the comments in the code when the attendee copy the codes including comments then paste them in the Java file. For example, they return a newline after existing comment(i.e. // TODO: Construct a simple...) then paste the codes and comments from the instruction.

For #line 481, if you mean to use "-f /projects/dg8-workshop/dg8-exercises" in maven build, it's fine by me to rollback not to use and add the previous note at the begging of the exercise. The reason why I updated is that I was asked 3~4 SAs had the same issue that they skipped to change the path. So if this happened in SAs, customers(devs) could do the same mistake. How about restoring the notes(make sure to use the correct path) then use the -f option at the same time to avoid unnecessary mistakes?