search

RedHat-SP-Security / tang-operator-tests

Upstream repository for tang-operator test suite
GNU General Public License v3.0
1 stars 1 forks source link

Remove install setup and use from common repo #92

Closed Koncpa closed 6 months ago

Koncpa commented 8 months ago

Also adjust upstream .fmf plan and check channel just under condition, if it's deployment provided via oc client.

Koncpa commented 8 months ago

/packit test

Koncpa commented 8 months ago

/packit test

Koncpa commented 7 months ago

/packit test

Koncpa commented 7 months ago

There is issue with version of GO on used releases is version of GO around 1.21, but when building a image need go >= 1.22.0.

go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240327193027-21368602d84b go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest: sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240327193027-21368602d84b requires go >= 1.22.0 (running go 1.21.8; GOTOOLCHAIN=local) make: *** [Makefile:247: /var/tmp/tang-operator_sources/bin/setup-envtest] Error 1

What we need to is use rawhide release, where we could get newer version of GO, but there is another issue with panic error of building image which we discussed before. My suggestion is run it just for Fedora-Rawhide and upgrade version for GO 1.22, but we need to handle that panic errors. @sarroutbi WDYT?

sarroutbi commented 7 months ago

There is issue with version of GO on used releases is version of GO around 1.21, but when building a image need go >= 1.22.0.

go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240327193027-21368602d84b go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest: sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240327193027-21368602d84b requires go >= 1.22.0 (running go 1.21.8; GOTOOLCHAIN=local) make: *** [Makefile:247: /var/tmp/tang-operator_sources/bin/setup-envtest] Error 1

What we need to is use rawhide release, where we could get newer version of GO, but there is another issue with panic error of building image which we discussed before. My suggestion is run it just for Fedora-Rawhide and upgrade version for GO 1.22, but we need to handle that panic errors. @sarroutbi WDYT?

Sorry, I don't understand your point ... it seems that the fix works properly in Rawhide, right? I still need to review the issue with Go 1.22, but I don't believe this is the issue here, as Rawhide seems to work appropriately ...

BTW, why do you need to compile the code? Shouldn't it be enough to download "latest" image from quay.io?

Koncpa commented 7 months ago

Yeah, but for rawhide we don't install upstream operator.. also when you look more careful into f38 and f39 results, there is error which I printed above, it's just false positive result, it's easy to miss. [1]

[1] https://artifacts.dev.testing-farm.io/d9dfeaed-4a30-43aa-a0ea-048fba4f8eb9/work-upstream-operator-all-testss_qvztox/Plans/upstream-operator-all-tests/execute/data/guest/default-0/Configure_test_system/Setup/install_upstream_operator-2/output.txt

Koncpa commented 7 months ago

And about compilation, we agreed, that could be useful in case, when we would like to check how upstream changes affect testing..also in future, when we setup CI for upstream code, we could use that upstream task for testing in upstream PR's. It's much easier to compile it, than every change upload it to quay.io..

sarroutbi commented 7 months ago

My suggestion to fix this, at this moment, is to not build the operator (this should not be the tests mission), and use, if possible, the image: quay.io/sec-eng-special/tang-operator-bundle:latest, as this is the latest official image for tang-operator

sarroutbi commented 7 months ago

And about compilation, we agreed, that could be useful in case, when we would like to check how upstream changes affect testing..also in future, when we setup CI for upstream code, we could use that upstream task for testing in upstream PR's. It's much easier to compile it, than every change upload it to quay.io..

Regarding this, IMHO, you have to be aware that non official builds could be causing issues in test execution. tang-operator is a "released early, released often" operator, that is released very frequently, so I would not mess with its compilation in test execution (I guess tests are not normally compiling RPMs, and they just use the RPMs required for the tests, normally the latest ones). But it is a matter of taste ... if you wish to keep compiling it, then you have to wait for the operator to work with latest Golang version, 1.22, which is not planned in the short term

Koncpa commented 7 months ago

For now we use both option, but I would at least open issue for it in tang-operator upstream to address issue, with panic errors.

Koncpa commented 7 months ago

I would not set high priority here, but I would at least file that issue. Everybody, who will try to build upstream could met with same issue.

sarroutbi commented 7 months ago

For now we use both option, but I would at least open issue for it in tang-operator upstream to address issue, with panic errors.

Absolutely. It was opened some time ago: https://github.com/latchset/tang-operator/issues/248

I have it in my TODO list

Koncpa commented 7 months ago

/packit test

Koncpa commented 6 months ago

/packit test

Koncpa commented 6 months ago

/packit test

sarroutbi commented 6 months ago

For now we use both option, but I would at least open issue for it in tang-operator upstream to address issue, with panic errors.

Absolutely. It was opened some time ago: latchset/tang-operator#248

I have it in my TODO list

@Koncpa : latchset/tang-operator#248 has been resolved. It should work now