RedHat-UX / red-hat-design-system

Red Hat's Design System
https://ux.redhat.com
MIT License
92 stars 18 forks source link

[feat] `<rh-video-embed>` element #1247

Closed markcaron closed 3 weeks ago

markcaron commented 11 months ago

We need a new Video element/component with the following criteria:

Mockups

markcaron commented 11 months ago

@marionnegp can you provide the assets for this? Seems like there's a logo backdrop behind the cookie consent.

marionnegp commented 11 months ago

cookie-opt-in-video-thumbnail-bg

@markcaron

bennypowers commented 11 months ago

prior art:

markcaron commented 10 months ago

@nikkimk to do some discovery work around whether there is a need for separate components/elements for 3rd party videos vs. the native <video> element, and how we'd tackle the APIs.

coreyvickery commented 9 months ago

@nikkimk @hellogreg Proposing to move this to the Chansey release.

hellogreg commented 9 months ago

@coreyvickery Done. Thanks! If we decide it needs to go to Charmander, we can do that, too.

nikkimk commented 6 months ago

Questions for discussion at Monday's office hours:

bennypowers commented 6 months ago
nikkimk commented 6 months ago
  • Should the component open the cookies dialog out of the box, or is this a pattern that consumers have to implement? Nikki will reach out to ask more about the cookies modal.
  • Given there's a lot of microcopy, do we handle it like audio player with translations, have the consumers slot in their own text, or some other method? Microcopy will be slotted. English will be default text in the slot, but patterns in Drupal should explicitly slot in microcopy for translations.
nikkimk commented 6 months ago

For the opt-in part: