RedHat-UX / red-hat-design-system

Red Hat's Design System
https://ux.redhat.com
MIT License
91 stars 18 forks source link

[feat] Create `<rh-icon>` element #1657

Closed markcaron closed 1 week ago

markcaron commented 2 months ago

With RH Icons updated, we need to get <rh-icon> out the door as soon as possible.

I'm assuming the underlying code will be very much like PF Icon if not identical, but using RH Icon SVGs.

For example:

<rh-icon icon="acorn" icon-set="standard">

Sets

  1. Standard (Default)
  2. UI
  3. Micron
  4. Social
marionnegp commented 1 month ago

@markcaron @bennypowers, according to the Brand site's info about icons, icons shouldn't be any bigger than 100px. Our largest icon size token is 128px. Should we remove that icon size and have our largest icon size token be 96px?

marionnegp commented 1 month ago

Updated icon set sizes from Brand:

They don't have specific guidelines for social icons, but they should generally be used like UI icons.

marionnegp commented 1 month ago

@coreyvickery @markcaron, could you take a look at the docs for <rh-icon>? I added a couple comments that the code on the Accessibility subpage could change after development is done.