RedHat-UX / red-hat-design-system

Red Hat's Design System
https://ux.redhat.com
MIT License
94 stars 18 forks source link

[feat] `<rh-tooltip>`: change the border-radius #1840

Closed marionnegp closed 1 week ago

marionnegp commented 1 week ago

Description

<rh-tooltip> in our Figma library currently has slightly rounded corners, and it would be good to update the code for <rh-tooltip> to use --rh-border-radius-default.

Suggested solution

To dos:

Screenshots

No response

Example API

No response

Additional context

No response

marionnegp commented 1 week ago

@coreyvickery, wanted to alert you to this small change. @markcaron @hellogreg, would you prefer to map this to Clefairy or Cubone?

zeroedin commented 1 week ago

@coreyvickery, wanted to alert you to this small change. @markcaron @hellogreg, would you prefer to map this to Clefairy or Cubone?

Because this is just a style change IMHO can just be a patch. See https://github.com/RedHat-UX/red-hat-design-system/pull/1841

I also updated the logical properties for positioning as well as removed some deprecated undocumented CSS custom properties in that PR.

coreyvickery commented 1 week ago

@zeroedin Good stuff!

bennypowers commented 1 week ago

cc @dustinmazon who kindly drew our attention to this issue