RedHat-UX / red-hat-design-system

Red Hat's Design System
https://ux.redhat.com
MIT License
98 stars 20 forks source link

[bug][docs] `<rh-accordion>` accent demos #1846

Closed marionnegp closed 1 month ago

marionnegp commented 1 month ago

Describe the bug

In the full screen demos for <rh-accordion>, an additional tag with two icons get added for each purposely placed tag:

Screenshot 2024-09-09 at 2 42 35 PM

Also, the "Accents Bottom" demo doesn't show the tags below the header. Screenshot 2024-09-09 at 2 49 09 PM

Screenshots

No response

Steps to reproduce

Go to the accordion's "Accents" demo or "Accents bottom" demo.

Expected behaviour

The tags should look similar to what's in the image for the accent slot docs.

Element HTML

No response

Operating System (OS)

macOS

Browser

Chrome

Additional browser or assistive technology info

No response

marionnegp commented 1 month ago

@markcaron @hellogreg, I've added this under Clefairy, but feel free to move it around if it's not a high priority.

bennypowers commented 1 month ago

Make sure icon gets loaded on the demo page and that the hydration shim loads before any component definitions

bennypowers commented 1 month ago

1853 should fix this. see DP