[feat] `<rh-navigation>` ready to migrate

RedHat-UX / red-hat-design-system

Red Hat's Design System

https://ux.redhat.com

MIT License

96 stars 18 forks source link

[feat] `<rh-navigation>` ready to migrate #375

Open markcaron opened 2 years ago

markcaron commented 2 years ago

Tag Name

rh-navigation

RHDS Only

[X] The component will be RHDS only, delete the PFE component once published

Todos

[ ] On what we should do with pfe-navigation right meow.

markcaron commented 2 years ago

Make sure this issue is fixed in new RH version: https://github.com/patternfly/patternfly-elements/issues/795

heyMP commented 2 years ago

Here is the list of bugs we identified in post launch design review: https://github.com/patternfly/patternfly-elements/issues/2023

bennypowers commented 2 years ago

let's consider renaming this to ~~rh-${page|main|primary}-nav~~ rh-navigation-primary, so pair with ~~rh-secondary-nav~~ rh-navigation-secondary and to contrast with the unrelated PFv4 navigation component

kelsS commented 3 months ago

@markcaron @bennypowers I am working on n rhds version of the primary nav. Is that okay or is someone already working on it?

bennypowers commented 1 week ago

https://github.com/orgs/RedHat-UX/discussions/1624 https://github.com/RedHat-UX/red-hat-design-system/issues/868 https://github.com/RedHat-UX/red-hat-design-system/issues/375 https://github.com/RedHat-UX/red-hat-design-system/issues/310