search

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms
Apache License 2.0
5 stars 13 forks source link

Change collector to support deep nested relations #10

Closed Fryguy closed 5 years ago

Fryguy commented 5 years ago

@agrare Please review.

Fryguy commented 5 years ago

I need to add more tests to handle the various nested relations, e.g. has_many, has_one, etc. I also would like to test double nested has_many, such as disks -> partitions -> volumes.

agrare commented 5 years ago

Nice no N+1 :+1:

Fryguy commented 5 years ago

@agrare Let's get this merged, and I'll do a follow up with the tests.

agrare commented 5 years ago

:+1: sounds good @Fryguy