Add Cloud Services UI - Githubissues

PanSpagetka commented 5 years ago

Add Cloud Services UI.

Known issues:

Buttons are not working (API is not done yet)
~~Type should be in more human readable form~~
~~Red Hat Cloud Services does not fit into menu, can we have something shorter?~~
No redirect to Cloud Services

Screenshot: Screenshot from 2019-06-27 11-06-21

ping @martinpovolny @h-kataria @Hyperkid123

terezanovotna commented 5 years ago

for Red Hat Cloud Services in the menu, can we have Red Hat new logo as an icon?
we can abbreviate it to RH Cloud Services for now

For type, how about dividing it into two columns? (dropping words ManageIQ and Providers)

Provider: Amazon, Ansible Tower, Azure etc.
Type: Cloud Manager, Storage Manager, Network Manager etc.

terezanovotna commented 5 years ago

What happens when the user clicks on the synchronize? can we show some kind of status info? it would be helpful to show that.

PanSpagetka commented 5 years ago

What happens when the user clicks on the synchronize? can we show some kind of status info? it would be helpful to show that.

@terezanovotna I have discussed with @lpichler and if I understand it correctly it will initiate task that will upload data from ManageIQ to Cloud Services. That could take some time so there is no immediate feedback. I could add "Synchronization task was initiated." flash message, but that's it.

Fryguy commented 5 years ago

@terezanovotna Previously we had the Insights left-side menu as the second from the top (under Cloud Intel). Do we still want it there? (This plugin is replacing that plugin)

EDIT: (screenshot for reference regarding the "old" plugin)

CFME: Infrastructure Providers 2019-06-28 11-21-50

Fryguy commented 5 years ago

but considering we are kind of in hurry

Are we?

Fryguy commented 5 years ago

or Red Hat Cloud Services in the menu, can we have Red Hat new logo as an icon? we can abbreviate it to RH Cloud Services for now

If we are going to have the logo, then do we need "RH" at all? Perhaps just "Cloud Services"?

Fryguy commented 5 years ago

@PanSpagetka This looks great! A couple of questions...

What does the "Upload" button do? Is that for the "core" (non-provider) data collection? If so, that's not clear to me.
I don't think we should show the type column as that's an insider thing. Perhaps instead show .class.description (e.g. for vmware it would show "VMware vCenter")?

martinpovolny commented 5 years ago

What does the "Upload" button do? Is that for the "core" (non-provider) data collection? If so, that's not clear to me.

According to @h-kataria, this is for uploading all data. That is both non-provider and provider. Can you, please, confirm that @h-kataria?

martinpovolny commented 5 years ago

What happens when the user clicks on the synchronize? can we show some kind of status info? it would be helpful to show that.

@terezanovotna: One time data upload will be attempted.

As far as I know, there's no status info (yet) on the backend. Can you confirm that @Fryguy ?

h-kataria commented 5 years ago

What does the "Upload" button do? Is that for the "core" (non-provider) data collection? If so, that's not clear to me.

According to @h-kataria, this is for uploading all data. That is both non-provider and provider. Can you, please, confirm that @h-kataria?

@Fryguy "Upload" button will upload ALL MIQ data to Cloud and "Synchronize" button will only upload data for selected Providers. That's what was discussed with you, @gtanzillo and @Loicavanel during our conversation in Mahwah.

PanSpagetka commented 5 years ago

API doesn't return any human readable type. .class.description is not accessible (or at least I don't know how), but I have added second API call so I can convert it. Some providers still don't have description, but I think that they shouldn't be present in the list (mostly Network Managers).

Screenshot: Screenshot from 2019-07-01 11-49-43

terezanovotna commented 5 years ago

@PanSpagetka @h-kataria @martinpovolny and Loic discussed this on BJ today.

Here is an updated version of how UI should look like. Please share any feedback in the comments to help us clarify what we have as Robin is implementing it.

https://marvelapp.com/i6c3d3j/screen/58779044 (there are 3 screens, click through)

@Fryguy When a user clicks on Synchronize button, we need some kind of feedback loop to tell him what is happening. Do we have that information?

For example:

if it's loading 45 seconds, we want to tell the user it is being synchronized - with a spinner
when clicked on the synchonize button, do we have any status info that we can share with the user?

@Fryguy thoughts? what's on your roadmap regarding the feedback loop?

PanSpagetka commented 5 years ago

I have implemented new design with Loic's comment. When user click on synchronize button, it shows flash message.

Screenshots: Screenshot from 2019-07-02 14-48-37

h-kataria commented 5 years ago

@Loicavenel @terezanovotna cc

martinpovolny commented 5 years ago

@h-kataria: Given this whole repo is a work in progress I think we can merge this and do follow up work in a separate PR or PRs.

Loicavenel commented 5 years ago

@h-kataria Platform Synchronization is confusing. Let's call it "Global Synchronization"

h-kataria commented 5 years ago

@martinpovolny do you have merge rights on this repo, if you have them, let's merge this PR. @PanSpagetka can create a follow up PR to make other changes.

Fryguy commented 5 years ago

+1 on merge and follow up. Also, I'll get permissions sorted out after this.

martinpovolny commented 5 years ago

Yes, I have the merge perms, but did not want to merge it w/o your say ;-)

@Fryguy: can you, please, give the perms to @h-kataria too?

terezanovotna commented 5 years ago

@inoxx03 is going to help us with wording!

RedHatCloudForms / cfme-cloud_services

Add Cloud Services UI #11